Repository navigation
Include KohakuFA-CuTe dependencies in CUDA extras - #3302
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUDA installations currently need a separate
attention-cuteextra before automatic KohakuFA-CuTe selection can use the vendored kernels. Include CUTLASS DSL, TVM FFI, and Ninja in thecudaandcuda13extras, including their nightly variants, using a shared dependency list. Remove the separate extra.Update the installation guide, attention option documentation, and Krea2/MOSS-Image installation instructions in English and all five translations. Document the C++17 compiler requirement for the extension built on first use.
Validation:
.venv/bin/python -m unittest -v -f tests.test_setup_platform_dependencies tests.test_kohaku_fa— 25 tests completed successfully, with three CUDA kernel tests skipped on this machine.