Remove old sprite code not used by text2d - #25665
Open
IceSentry wants to merge 1 commit into
Open
Conversation
IceSentry
added
A-Rendering
agluszak
reviewed
Sep 3, 2026
| /// PERF: storing an `AssetId` instead of `Handle<Image>` enables some optimizations (`ExtractedSprite` becomes `Copy` and doesn't need to be dropped) | ||
| pub image_handle_id: AssetId<Image>, | ||
| pub flip_x: bool, | ||
| pub flip_y: bool, |
Contributor
There was a problem hiding this comment.
why is flip_x removed, but flip_y is not??
Contributor
Author
There was a problem hiding this comment.
Because flip_x was never used by any of the text2d code path but it does use flip_y
stuartparmenter
approved these changes
Sep 3, 2026
alice-i-cecile
added
C-Code-Quality
alice-i-cecile
approved these changes
Sep 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing