HitDataEvent trait - #25662
Open
laundmo wants to merge 1 commit into
Open
Conversation
alice-i-cecile
added
X-Uncontroversial
alice-i-cecile
requested changes
Sep 2, 2026
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Can you please cross-link this with the PointerEvent trait, and leave a doc comment explaining why they're not just one trait? :) I think I understand why, but it immediately came to mind and will be useful for others to understand the design.
Other than that, this LGTM.
alice-i-cecile
added
the
S-Waiting-on-Author
Member
Author
|
aye, putting it here till i'm back at PC: they mostly overlap in which types they're implemented for but not 100%. notably some events don't have hitdata |
laundmo
added
the
S-Adopt-Me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Trait which just exposes picking events HitData, similar to
PointerEvent. Makes it easier to write generic code over multiple picking event types.Solution
Create and implement trait
Testing