turn more types into wgpu wrappers - #25660
Open
laundmo wants to merge 1 commit into
Open
Conversation
laundmo
added
A-Rendering
alice-i-cecile
requested review from
stuartparmenter and
tychedelia
and removed request for
tychedelia
September 2, 2026 21:04
Member
|
@SkiFire13 want to review this one too? (once it's green) |
alice-i-cecile
added
X-Uncontroversial
laundmo
added
the
S-Adopt-Me
beicause
reviewed
Sep 8, 2026
Comment on lines
+27
to
+28
| wgpu_wrapper!(pub struct WgpuCommandBuffer(wgpu::CommandBuffer)); | ||
| wgpu_wrapper!(pub struct WgpuCommandEncoder(wgpu::CommandEncoder)); |
Member
There was a problem hiding this comment.
Using wgpu_wrapper! is only to allow wasm32 + atomics to make !Send wgpu resources compile. There is no need here because RenderContextState is already wrapped. Also, I don't see the reason why this would reduce compile time, ~1s could be noise.
And this leads to using into_inner() everywhere which seems bad to me.
stuartparmenter
suggested changes
Sep 8, 2026
stuartparmenter
left a comment
stuartparmenter
left a comment
Contributor
There was a problem hiding this comment.
This still needs work -- CI fixes, missed callers (DLSS, etc), migration guide, etc. I like faster compile times, and am supportive of the work, but I don't love needing to sprinkle into_inner().finish() everywhere.
Happy to review when it is ready to be reviewed.
alice-i-cecile
added
M-Migration-Guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #25512
improves bevy_render compile times by another ~1s for me
Testing
pan_orbit_camera_cadexample