Fix shader compile errors in custom_stencil.wesl and specialized_mesh_pipeline.wesl - #25439
Open
beicause wants to merge 5 commits into
Open
Fix shader compile errors in custom_stencil.wesl and specialized_mesh_pipeline.wesl#25439beicause wants to merge 5 commits into
custom_stencil.wesl and specialized_mesh_pipeline.wesl#25439beicause wants to merge 5 commits into
Conversation
beicause
changed the title
custom_stencil.wesl
beicause
added
C-Bug
kfc35
added
the
D-Straightforward
beicause
changed the title
custom_stencil.weslcustom_stencil.wesl and specialized_mesh_pipeline.wesl
JMS55
reviewed
Sep 4, 2026
JMS55
reviewed
Sep 4, 2026
JMS55
reviewed
Sep 4, 2026
JMS55
reviewed
Sep 4, 2026
| .with_removed_attribute(Mesh::ATTRIBUTE_NORMAL) | ||
| .with_removed_attribute(Mesh::ATTRIBUTE_UV_0) | ||
| .compressed_mesh( | ||
| MeshAttributeCompressionFlags::all() |
Contributor
There was a problem hiding this comment.
Why .with_color(MeshAttributeCompressionFlags::COMPRESS_COLOR_UNORM8), when it has no color attribute?
Member
Author
There was a problem hiding this comment.
Color float16 and unorm8 are mutually exclusive bit flags so MeshAttributeCompressionFlags::all() is a footgun that constructs an invalid color bit field (#24572 will address it). Though without the vertex color the flags are unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix shader compile errors in the
custom_stencil.weslandspecialized_mesh_pipeline.wesl:mesh_uniform.aabb_center,mesh_uniform.aabb_half_extentsdo not exist.Solution
Use
mesh_functions::get_metadatainstead.Testing
Added compressed mesh to the
custom_render_phaseandspecialized_mesh_pipelineexamples and ran them.