Testing multi kibana#102
Open
coutoPL wants to merge 3 commits into
Open
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ror-demo-cluster/.env-showcase`:
- Around line 13-18: Add a short inline comment in
ror-demo-cluster/.env-showcase next to KBN_ROR_FILE and KBN2_ROR_FILE explaining
why the two different ROR Kibana plugin pre-release versions are used (e.g.,
intentional compatibility/upgrade testing, regression comparison between pre15
and pre16), so future readers understand the divergence; update the lines
referencing KBN_ROR_FILE and KBN2_ROR_FILE to include that brief intent note
directly above or on the same line.
In `@ror-demo-cluster/conf/kbn/enterprise-ror-newplatform-kibana.yml`:
- Line 19: The current setting readonlyrest_kbn.logLevel: trace is unsafe for
production; change it to a less verbose level (e.g., info or warn) and implement
environment-controlled switching so trace is only enabled for local
debugging—replace the hardcoded readonlyrest_kbn.logLevel value with an
environment variable reference (or use a separate debug config) and add a
comment documenting that trace must never be deployed to production; locate and
update the readonlyrest_kbn.logLevel entry in the kibana config to apply this
change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2c9864eb-4b47-4bfc-8938-31472f42d28b
⛔ Files ignored due to path filters (2)
ror-demo-cluster/readonlyrest_kbn_universal-1.70.0-pre15_es9.0.0.zipis excluded by!**/*.zipror-demo-cluster/readonlyrest_kbn_universal-1.70.0-pre16_es9.0.0.zipis excluded by!**/*.zip
📒 Files selected for processing (3)
ror-demo-cluster/.env-showcaseror-demo-cluster/conf/kbn/enterprise-ror-newplatform-kibana.ymlror-demo-cluster/docker-compose.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- ror-demo-cluster/docker-compose.yml
Comment on lines
+13
to
+18
| KBN_DOCKERFILE=Dockerfile-use-ror-binaries-from-file | ||
| KBN_ROR_FILE=readonlyrest_kbn_universal-1.70.0-pre15_es9.0.0.zip | ||
|
|
||
| KBN2_VERSION=9.0.0 | ||
| KBN2_DOCKERFILE=Dockerfile-use-ror-binaries-from-file | ||
| KBN2_ROR_FILE=readonlyrest_kbn_universal-1.70.0-pre16_es9.0.0.zip |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify that the specified ROR plugin artifacts exist
# Check if KBN_ROR_FILE exists
if [ -f "readonlyrest_kbn_universal-1.70.0-pre15_es9.0.0.zip" ]; then
echo "✓ KBN_ROR_FILE exists: readonlyrest_kbn_universal-1.70.0-pre15_es9.0.0.zip"
else
echo "✗ KBN_ROR_FILE not found: readonlyrest_kbn_universal-1.70.0-pre15_es9.0.0.zip"
fi
# Check if KBN2_ROR_FILE exists
if [ -f "readonlyrest_kbn_universal-1.70.0-pre16_es9.0.0.zip" ]; then
echo "✓ KBN2_ROR_FILE exists: readonlyrest_kbn_universal-1.70.0-pre16_es9.0.0.zip"
else
echo "✗ KBN2_ROR_FILE not found: readonlyrest_kbn_universal-1.70.0-pre16_es9.0.0.zip"
fi
# Check if ES_ROR_FILE exists
if [ -f "readonlyrest-1.70.0-pre10_es9.0.0.zip" ]; then
echo "✓ ES_ROR_FILE exists: readonlyrest-1.70.0-pre10_es9.0.0.zip"
else
echo "✗ ES_ROR_FILE not found: readonlyrest-1.70.0-pre10_es9.0.0.zip"
fiRepository: beshu-tech/ror-sandbox
Length of output: 286
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the env-showcase snippet with context
echo "== ror-demo-cluster/.env-showcase =="
sed -n '1,120p' ror-demo-cluster/.env-showcase || true
# Find where these env vars are referenced
echo "== Search for KBN_ROR_FILE and KBN2_ROR_FILE =="
rg -n "KBN_ROR_FILE|KBN2_ROR_FILE" . || true
echo "== Search for referenced ZIP filenames =="
rg -n "readonlyrest_kbn_universal-1\.70\.0-pre15_es9\.0\.0\.zip|readonlyrest_kbn_universal-1\.70\.0-pre16_es9\.0\.0\.zip|readonlyrest-1\.70\.0-pre10_es9\.0\.0\.zip" . || true
# Locate any scripts that download artifacts (best-effort)
echo "== Search for 'wget|curl|download|artifacts|zip' usage =="
rg -n "wget|curl|download|artifacts|readonlyrest.*\.zip|\.zip" . || trueRepository: beshu-tech/ror-sandbox
Length of output: 10582
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Tree: ror-demo-cluster =="
ls -la ror-demo-cluster || true
find ror-demo-cluster -maxdepth 2 -type f -print || true
echo "== Show ror-demo-cluster/docker-compose.yml (relevant env wiring) =="
sed -n '1,220p' ror-demo-cluster/docker-compose.yml || true
echo "== Search for pre15/pre16 rationale mentions =="
rg -n "pre15|pre16" . || true
echo "== Show ror-demo-cluster/run.sh or readme (if exists) =="
ls -la ror-demo-cluster | sed -n '1,200p'
rg -n "ROR_FILE|KBN_ROR_FILE|KBN2_ROR_FILE|ROR plugin|download.*zip|use-ror-binaries-from-file" -S ror-demo-cluster . || true
# Locate how Dockerfile-use-ror-binaries-from-file expects the zip to be present
echo "== Show Dockerfile-use-ror-binaries-from-file for kbn/es (if present) =="
sed -n '1,120p' ror-demo-cluster/images/kbn/Dockerfile-use-ror-binaries-from-file 2>/dev/null || true
sed -n '1,160p' ror-demo-cluster/images/es/Dockerfile-use-ror-binaries-from-file 2>/dev/null || trueRepository: beshu-tech/ror-sandbox
Length of output: 14809
Document the intent of using different ROR Kibana plugin pre versions (pre15 vs pre16)
In ror-demo-cluster/.env-showcase, KBN_ROR_FILE uses readonlyrest_kbn_universal-1.70.0-pre15_es9.0.0.zip while KBN2_ROR_FILE uses readonlyrest_kbn_universal-1.70.0-pre16_es9.0.0.zip. The referenced ZIPs for both Kibana instances are present under ror-demo-cluster/, so the mismatch is not a missing-artifact issue—still, this version divergence can produce different runtime behavior between the two Kibana instances. Add a short comment explaining why pre15 vs pre16 is used (e.g., upgrade/downgrade compatibility testing).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ror-demo-cluster/.env-showcase` around lines 13 - 18, Add a short inline
comment in ror-demo-cluster/.env-showcase next to KBN_ROR_FILE and KBN2_ROR_FILE
explaining why the two different ROR Kibana plugin pre-release versions are used
(e.g., intentional compatibility/upgrade testing, regression comparison between
pre15 and pre16), so future readers understand the divergence; update the lines
referencing KBN_ROR_FILE and KBN2_ROR_FILE to include that brief intent note
directly above or on the same line.
| readonlyrest_kbn.logLevel: info | ||
|
|
||
| readonlyrest_kbn.store_sessions_in_index: true | ||
| readonlyrest_kbn.logLevel: trace |
Contributor
There was a problem hiding this comment.
Trace logging exposes sensitive data and impacts performance.
Setting logLevel to trace produces extremely verbose output that can leak sensitive information such as authentication tokens, user credentials, session data, and potentially PII. It also degrades performance significantly. While appropriate for local debugging, ensure this configuration is never deployed to production or shared environments.
🔒 Recommended fix for production-safe logging
-readonlyrest_kbn.logLevel: trace
+readonlyrest_kbn.logLevel: infoIf trace logging is required temporarily for debugging, consider:
- Documenting the temporary nature with a comment
- Creating a separate config file for debug scenarios
- Using environment variable substitution to control log level per deployment
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| readonlyrest_kbn.logLevel: trace | |
| readonlyrest_kbn.logLevel: info |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ror-demo-cluster/conf/kbn/enterprise-ror-newplatform-kibana.yml` at line 19,
The current setting readonlyrest_kbn.logLevel: trace is unsafe for production;
change it to a less verbose level (e.g., info or warn) and implement
environment-controlled switching so trace is only enabled for local
debugging—replace the hardcoded readonlyrest_kbn.logLevel value with an
environment variable reference (or use a separate debug config) and add a
comment documenting that trace must never be deployed to production; locate and
update the readonlyrest_kbn.logLevel entry in the kibana config to apply this
change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Updates
Configuration Changes