Skip to content

Conversation

@AndreiDurlea
Copy link

@AndreiDurlea AndreiDurlea commented Feb 10, 2026

@AndreiDurlea AndreiDurlea marked this pull request as draft February 10, 2026 19:16
@AndreiDurlea
Copy link
Author

@neatudarius is this ok to merge?

@coveralls
Copy link

coveralls commented Feb 10, 2026

Pull Request Test Coverage Report for Build 21878967911

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 99.038%

Files with Coverage Reduction New Missed Lines %
include/beman/optional/optional.hpp 2 98.99%
Totals Coverage Status
Change from base Build 21867776355: -0.1%
Covered Lines: 309
Relevant Lines: 312

💛 - Coveralls

// include/beman/optional/detail/stl_interfaces/iterator_interface.hpp -*-C++-*-
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

// Copyright (C) 2019 T. Zachary Laine
Copy link
Member

@neatudarius neatudarius Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution Andrei! It seems we havr an unexpected case here, I didn't anticipate these files need to be updated.

We need to remove these lines to be Beman Standard compliant with include/. I'm not sure if we can legally do this with the this header which was copied from @tzlaine . @steve-downey ?

v1: directly remove the copyright line
v2: move stl interfaces into a special whitelisted directory (e.g., external/, deps/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants