Skip to content

fix(numberbox): skip traversal and inline buttons#1332

Merged
bdlukaa merged 3 commits into
bdlukaa:masterfrom
WinXaito:hotfix/numberbox_focus
Jun 10, 2026
Merged

fix(numberbox): skip traversal and inline buttons#1332
bdlukaa merged 3 commits into
bdlukaa:masterfrom
WinXaito:hotfix/numberbox_focus

Conversation

@WinXaito

@WinXaito WinXaito commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

I had some focus problems with the NumberBox (some ghost focus, handled by the Focus widget) and I don't think its relevant to have a focus on the inline button (if we works with the keyboard, we usually don't want the focus on the inline button. I may add a parameter for that if its necessary)

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project (not on example app, lot of changes)
  • I have added/updated relevant documentation

Before:

before.mp4

After:

after.mp4
Before / After with different Spin Buttons:

Before (inline mode):

before_2.mp4

After (compact)

after_2.mp4

After (inline)

after_3.mp4

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses focus issues in the NumberBox widget by setting skipTraversal: true on its outer Focus widget and making the inline spin buttons non-focusable (focusable: false). A review comment identifies a typo in the CHANGELOG.md entry where "anymoregit" was written instead of "anymore" and provides a suggestion to fix it.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread CHANGELOG.md Outdated
@bdlukaa bdlukaa merged commit 2e763eb into bdlukaa:master Jun 10, 2026
2 of 3 checks passed
@WinXaito WinXaito deleted the hotfix/numberbox_focus branch June 11, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants