fix(numberbox): skip traversal and inline buttons#1332
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses focus issues in the NumberBox widget by setting skipTraversal: true on its outer Focus widget and making the inline spin buttons non-focusable (focusable: false). A review comment identifies a typo in the CHANGELOG.md entry where "anymoregit" was written instead of "anymore" and provides a suggestion to fix it.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
bdlukaa
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some focus problems with the NumberBox (some ghost focus, handled by the Focus widget) and I don't think its relevant to have a focus on the inline button (if we works with the keyboard, we usually don't want the focus on the inline button. I may add a parameter for that if its necessary)
Pre-launch Checklist
CHANGELOG.mdwith my changesBefore:
before.mp4
After:
after.mp4
Before / After with different Spin Buttons:
Before (inline mode):
before_2.mp4
After (compact)
after_2.mp4
After (inline)
after_3.mp4