Selection toolbar#1330
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames FluentTextSelectionToolbar and its associated selection controls to WindowsTextSelectionToolbar (marking the old names as deprecated), fixes a typo in the 'Search Web' label, and adds support for rendering non-standard context menu buttons. It also updates the example app and code snippet viewer to support text selection and custom context menus. The review feedback highlights critical compilation errors in the example app, including incorrect usage of the share_plus API, an undefined controller reference, an invalid const modifier on CodeSnippetCard, and the use of the deprecated toolbar class name within a documentation snippet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1317
Pre-launch Checklist
CHANGELOG.mdwith my changes