fix: add pg8000 graceful shutdown on Cloud Run scale-down#1669
Open
panish16 wants to merge 3 commits into
Open
fix: add pg8000 graceful shutdown on Cloud Run scale-down#1669panish16 wants to merge 3 commits into
panish16 wants to merge 3 commits into
Conversation
panish16
requested review from
Jacky-Pham,
JazzarKarim,
dimak1 and
thorwolpert
as code owners
panish16
changed the title
panish16
changed the title
panish16
force-pushed
the
fix/pg8000-graceful-shutdown
branch
from
09921be to
2b071bb
Compare
…email and strr-pay
panish16
force-pushed
the
fix/pg8000-graceful-shutdown
branch
from
2b071bb to
3780bf5
Compare
|
dimak1
approved these changes
Jun 11, 2026
| @@ -1,4 +1,186 @@ | |||
| # This file is automatically @generated by Poetry 2.3.4 and should not be changed by hand. | |||
| # This file is automatically @generated by Poetry 2.3.2 and should not be changed by hand. | |||
Collaborator
There was a problem hiding this comment.
poetry version is mismatched. is that intended?
| @@ -1,4 +1,186 @@ | |||
| # This file is automatically @generated by Poetry 2.3.4 and should not be changed by hand. | |||
| # This file is automatically @generated by Poetry 2.3.2 and should not be changed by hand. | |||
Collaborator
There was a problem hiding this comment.
same comment here as above about the poetry version
| # Path to sources | ||
| #sonar.sources=strr-api/src/**/* | ||
| sonar.exclusions=strr-api/migrations/**/*,strr-api/devops/**/*,strr-api/tests/**/*,testing/**/* | ||
| sonar.exclusions=strr-api/migrations/**/*,strr-api/devops/**/*,strr-api/tests/**/*,testing/**/*,queue_services/**/tests/**/* |
Collaborator
There was a problem hiding this comment.
whats the reason for adding this?
Collaborator
|
hey @panish16 thanks for integrating the |
| assert stored.meta_data["email_type"] == "STRATA_HOTEL_REGISTRATION_ACTIVE" | ||
|
|
||
|
|
||
| def test_email_no_cloud_event_data(client, queue_envelope, simple_cloud_event): |
Collaborator
There was a problem hiding this comment.
what are these unit & integration tests added for in this project?
wasnt it already at 100% coverage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectevent listener on app startup that wraps each pg8000 connection'sclose()to suppresspg8000.exceptions.InterfaceErrorduring Cloud Run scale-downpg8000.exceptions.InterfaceError: network errorlogged when Cloud Run terminates idle instances and SQLAlchemy's connection pool teardown tries to close already-severed socketsstrr-emailandstrr-payconnect via Unix socket (no Cloud SQL Connector dependency), so the listener is implemented inline using the same logicServices fixed
queue_services/strr-email/src/strr_email/__init__.pyqueue_services/strr-pay/src/strr_pay/__init__.pyTest plan
pg8000.exceptions.InterfaceErrorentries in GCP Log Explorer forbcrbk9-prodproject after deployment