Skip to content

DBC22-6623: Fix few issues with django image#1359

Open
wmuldergov wants to merge 2 commits into
mainfrom
task/DBC22-6623
Open

DBC22-6623: Fix few issues with django image#1359
wmuldergov wants to merge 2 commits into
mainfrom
task/DBC22-6623

Conversation

@wmuldergov

@wmuldergov wmuldergov commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes/No)

    If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

  1. Deploy to dev
  2. Confirm build works
  3. Confirm django still works as expected. The logs should show no errors and the reloader should also not be running there.
  4. Try run docker compose locally and confirm it builds and runs as expected still. It should use the Dockerfile.dev and the start_local.sh script.

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

@wmuldergov wmuldergov added the ready for review The PR is ready for review label Jun 2, 2026
@wmuldergov wmuldergov requested a review from bcgov-brwang June 2, 2026 21:31
@wmuldergov wmuldergov removed the ready for review The PR is ready for review label Jun 2, 2026
@wmuldergov wmuldergov changed the title DBC22-6623: Fix dependabot and prod dockerfile DBC22-6623: Fix few issues with django image Jun 2, 2026
@wmuldergov wmuldergov added ready for review The PR is ready for review and removed ready for review The PR is ready for review labels Jun 2, 2026
@wmuldergov wmuldergov marked this pull request as draft June 3, 2026 14:53
@wmuldergov wmuldergov removed the request for review from bcgov-brwang June 3, 2026 14:53
@wmuldergov wmuldergov force-pushed the task/DBC22-6623 branch 4 times, most recently from d8d127e to ed733e8 Compare June 3, 2026 21:57
@wmuldergov wmuldergov requested a review from bcgov-brwang June 3, 2026 22:56
@wmuldergov wmuldergov marked this pull request as ready for review June 3, 2026 22:56
@wmuldergov wmuldergov added the ready for review The PR is ready for review label Jun 3, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 5, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant