Skip to content

fix: switch agent main_test gexec.Build to canonical pattern #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bborbe wants to merge 4 commits into from
Closed

fix: switch agent main_test gexec.Build to canonical pattern #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fa5414
fix: switch agent main_test gexec.Build to canonical pattern
bborbe May 26, 2026
576b2dc
fix: replace gexec.Build with direct exec.Command in root agent main_…
bborbe May 26, 2026
3fb7eea
fix: drop explicit Compiles spec from root agent main_test
bborbe May 26, 2026
8562b36
fix: drop Compiles spec from all agent cmd/run-task main_test
bborbe May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions agent/claude/cmd/run-task/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,22 @@

package main_test

//go:generate go run -mod=mod github.com/maxbrunsfeld/counterfeiter/v6 -generate

import (
"testing"
"time"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/onsi/gomega/format"
"github.com/onsi/gomega/gexec"
)

var _ = Describe("Main", func() {
It("Compiles", func() {
var err error
_, err = gexec.Build(
"github.com/bborbe/agent/agent/claude/cmd/run-task",
"-mod=mod",
)
Expect(err).NotTo(HaveOccurred())
})
})
// NOTE: Explicit "Compiles" spec removed because spawning a child
// process from this race-instrumented test binary segfaults randomly
// on the GH Actions runner (works locally; only reproduces on Linux CI
// under -race). The test binary itself IS package main built — if
// main.go does not compile, `go test` fails immediately, so the
// assertion is redundant. See vault note [[Github Workflow Actions]]
// gotchas section for full diagnosis.

func TestSuite(t *testing.T) {
time.Local = time.UTC
Expand Down
14 changes: 6 additions & 8 deletions agent/claude/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,14 @@ import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/onsi/gomega/format"
"github.com/onsi/gomega/gexec"
)

var _ = Describe("Main", func() {
It("Compiles", func() {
var err error
_, err = gexec.Build("github.com/bborbe/agent/agent/claude", "-mod=mod")
Expect(err).NotTo(HaveOccurred())
})
})
// NOTE: Explicit "Compiles" spec removed because spawning a child
// process from this race-instrumented test binary segfaults on the
// GH Actions runner (works locally; only reproduces on Linux CI under
// -race). The test binary itself IS package main built — if main.go
// does not compile, `go test` fails immediately, so the assertion is
// redundant. See vault note [[Github Workflow Actions]] gotchas.

func TestSuite(t *testing.T) {
time.Local = time.UTC
Expand Down
18 changes: 7 additions & 11 deletions agent/code/cmd/run-task/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,15 @@ import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/onsi/gomega/format"
"github.com/onsi/gomega/gexec"
)

var _ = Describe("Main", func() {
It("Compiles", func() {
var err error
_, err = gexec.Build(
"github.com/bborbe/agent/agent/code/cmd/run-task",
"-mod=mod",
)
Expect(err).NotTo(HaveOccurred())
})
})
// NOTE: Explicit "Compiles" spec removed because spawning a child
// process from this race-instrumented test binary segfaults randomly
// on the GH Actions runner (works locally; only reproduces on Linux CI
// under -race). The test binary itself IS package main built — if
// main.go does not compile, `go test` fails immediately, so the
// assertion is redundant. See vault note [[Github Workflow Actions]]
// gotchas section for full diagnosis.

func TestSuite(t *testing.T) {
time.Local = time.UTC
Expand Down
18 changes: 7 additions & 11 deletions agent/gemini/cmd/run-task/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,15 @@ import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/onsi/gomega/format"
"github.com/onsi/gomega/gexec"
)

var _ = Describe("Main", func() {
It("Compiles", func() {
var err error
_, err = gexec.Build(
"github.com/bborbe/agent/agent/gemini/cmd/run-task",
"-mod=mod",
)
Expect(err).NotTo(HaveOccurred())
})
})
// NOTE: Explicit "Compiles" spec removed because spawning a child
// process from this race-instrumented test binary segfaults randomly
// on the GH Actions runner (works locally; only reproduces on Linux CI
// under -race). The test binary itself IS package main built — if
// main.go does not compile, `go test` fails immediately, so the
// assertion is redundant. See vault note [[Github Workflow Actions]]
// gotchas section for full diagnosis.

func TestSuite(t *testing.T) {
time.Local = time.UTC
Expand Down
18 changes: 7 additions & 11 deletions agent/pi/cmd/run-task/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,15 @@ import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/onsi/gomega/format"
"github.com/onsi/gomega/gexec"
)

var _ = Describe("Main", func() {
It("Compiles", func() {
var err error
_, err = gexec.Build(
"github.com/bborbe/agent/agent/claude/cmd/run-task",
"-mod=mod",
)
Expect(err).NotTo(HaveOccurred())
})
})
// NOTE: Explicit "Compiles" spec removed because spawning a child
// process from this race-instrumented test binary segfaults randomly
// on the GH Actions runner (works locally; only reproduces on Linux CI
// under -race). The test binary itself IS package main built — if
// main.go does not compile, `go test` fails immediately, so the
// assertion is redundant. See vault note [[Github Workflow Actions]]
// gotchas section for full diagnosis.

func TestSuite(t *testing.T) {
time.Local = time.UTC
Expand Down
14 changes: 6 additions & 8 deletions agent/pi/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,14 @@ import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/onsi/gomega/format"
"github.com/onsi/gomega/gexec"
)

var _ = Describe("Main", func() {
It("Compiles", func() {
var err error
_, err = gexec.Build("github.com/bborbe/agent/agent/pi", "-mod=mod")
Expect(err).NotTo(HaveOccurred())
})
})
// NOTE: Explicit "Compiles" spec removed because spawning a child
// process from this race-instrumented test binary segfaults on the
// GH Actions runner (works locally; only reproduces on Linux CI under
// -race). The test binary itself IS package main built — if main.go
// does not compile, `go test` fails immediately, so the assertion is
// redundant. See vault note [[Github Workflow Actions]] gotchas.

func TestSuite(t *testing.T) {
time.Local = time.UTC
Expand Down