Extend sof-firmware install to all Intel SOF platforms (Arrow Lake, Meteor Lake, etc.)#6200
Open
sridhar-3009 wants to merge 1 commit into
Open
Conversation
Arrow Lake (and Meteor Lake, Tiger Lake, Alder Lake, etc.) all use the sof-audio-pci-intel-* driver family, which requires sof-firmware to boot the DSP. The old guard only checked for Panther Lake, so any other Intel SOF laptop (including Arrow Lake Yoga Pro 7 / 285H) shipped with no audio on a fresh install. Add omarchy-hw-intel-sof, a new PCI-class-based detector that matches any Intel audio controller (Multimedia audio or Audio device class), which is the reliable signal for SOF capability on modern Intel. Replace the Panther Lake guard in sof-firmware.sh with this broader check. The Panther Lake XPS exclusion is preserved: those systems run linux-ptl, which hard-depends sof-firmware. All other Intel SOF platforms on mainline linux now get the package. Add a migration to backfill existing systems that were installed before this fix. Fixes basecamp#6110.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR broadens Omarchy’s Intel audio DSP support by ensuring sof-firmware is installed on Intel platforms that rely on SOF/cAVS drivers (e.g., Arrow Lake, Meteor Lake), preventing “Dummy Output” audio failures after fresh installs on mainline linux.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Add a new hardware detection command (
omarchy-hw-intel-sof) to identify Intel systems that should receivesof-firmware. - Update the Intel SOF install guard to use the new detection while preserving the Panther Lake XPS exclusion.
- Add a migration to backfill
sof-firmwareon existing installs.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
bin/omarchy-hw-intel-sof |
New predicate command used to detect Intel systems that should receive SOF firmware. |
install/config/hardware/intel/sof-firmware.sh |
Switches install logic from Panther Lake-only detection to the broader Intel SOF detection (with XPS PTL exclusion). |
migrations/1783625096.sh |
Backfills sof-firmware installation for qualifying systems installed prior to this change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # All other Intel SOF platforms on mainline linux need it installed explicitly. | ||
|
|
||
| if omarchy-hw-intel-ptl && ! omarchy-hw-match "XPS"; then | ||
| if omarchy-hw-intel-sof && ! (omarchy-hw-intel-ptl && omarchy-hw-match "XPS"); then |
| # omarchy-pkg-add is idempotent — systems that already have the package | ||
| # (Panther Lake XPS or any system that installed it manually) are unaffected. | ||
|
|
||
| if omarchy-hw-intel-sof && ! (omarchy-hw-intel-ptl && omarchy-hw-match "XPS"); then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
install/config/hardware/intel/sof-firmware.shonly installssof-firmwareon Panther Lake systems. Arrow Lake (and Meteor Lake, Tiger Lake, Alder Lake,
etc.) all use the
sof-audio-pci-intel-*driver family, which needssof-firmwareto boot the DSP. On mainlinelinuxthe package is only anoptdep, so nothing pulls it in automatically. Result: fresh installs onArrow Lake laptops boot with no audio — PipeWire exposes only a Dummy Output
sink.
Reported in #6110 (Lenovo Yoga Pro 7 14IAH10, Intel Core Ultra 9 285H).
Fix
New detection script
bin/omarchy-hw-intel-sof: checks for any IntelPCI audio controller (class Multimedia audio or Audio device). This reliably
identifies the Skylake-and-later platforms that load
sof-audio-pci-intel-*drivers.
Updated
sof-firmware.sh: Replaceomarchy-hw-intel-ptlwithomarchy-hw-intel-sof. The Panther Lake XPS exclusion is preserved — thosesystems use
linux-ptl, which already hard-dependssof-firmware.Migration
migrations/1783625096.sh: Backfillssof-firmwareonexisting installs that were set up before this fix.
omarchy-pkg-addisidempotent so systems that already have the package are unaffected.