fix: correct file extension and syntax in rounded-corners toggle#6194
Open
sridhar-3009 wants to merge 1 commit into
Open
fix: correct file extension and syntax in rounded-corners toggle#6194sridhar-3009 wants to merge 1 commit into
sridhar-3009 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Hyprland rounded-corners toggle by aligning it with Omarchy’s toggle loader expectations (Lua module files loaded via require_all.files() and selected by omarchy-hyprland-toggle using a hard-coded .lua extension).
Changes:
- Add
default/hypr/toggles/rounded-corners.luausing the requiredhl.config({ ... })Lua format. - Remove the old
default/hypr/toggles/rounded-corners.confHyprland-syntax file that could not be loaded by the toggles system.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| default/hypr/toggles/rounded-corners.lua | Adds the rounded-corners toggle in the correct Lua hl.config() module format. |
| default/hypr/toggles/rounded-corners.conf | Removes the invalid/non-loadable legacy toggle file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rounded-corners toggle file was named
rounded-corners.confbutomarchy-hyprland-togglelooks forrounded-corners.lua, causing "Flag not found" and a silent no-op. Additionally the file used plain Hyprland syntax instead of the Luahl.config()format required by the toggles system.This renames
rounded-corners.conftorounded-corners.luaand converts its content to the correct Lua module format matching other toggles likewindow-no-gaps.lua.Closes #6156