Skip to content

Keep the release dry-run switch out of the preflight checks #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robzolkos merged 2 commits into from
Nov 13, 2026
Merged

Keep the release dry-run switch out of the preflight checks #227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a839088
Let the release dry run pass the skills-sync test
robzolkos Nov 13, 2026
aa384bb
Keep the release switch out of the checks instead
robzolkos Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ if grep -q '^replace' go.mod; then
exit 1
fi

# DRY_RUN is this script's switch (0 or 1). The skills-sync test reads a DRY_RUN
# of its own, where only 'local' and 'remote' are valid, so keep this one out of
# the checks' environment. `make release DRY_RUN=1` also carries it into the
# nested make through MAKEFLAGS, which unsetting the shell variable does not
# undo, so the nested make is given an empty one.
release_check() {
env -u DRY_RUN make DRY_RUN= release-check
}

echo "Release preflight for $VERSION"
echo " Branch: $CURRENT_BRANCH"
echo " Commit: $LOCAL"
Expand All @@ -60,15 +69,15 @@ if [ "$DRY_RUN" = "1" ]; then
echo ""
echo "DRY RUN: Would run 'make release-check', tag $VERSION, and push"
echo "Running release-check..."
make release-check
release_check
echo ""
echo "DRY RUN complete. No tag created."
exit 0
fi

echo ""
echo "Running release-check..."
make release-check
release_check

echo ""
echo "Creating tag $VERSION..."
Expand Down
Loading