Skip to content

Fix three CI failures affecting every branch off main #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robzolkos merged 3 commits into from
Jul 10, 2026
Merged

Fix three CI failures affecting every branch off main #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f9e6a6
Use default Bundler on Ruby head
robzolkos Jul 3, 2026
e75f84e
Scan against latest Go patch in govulncheck
robzolkos Jul 10, 2026
ae8df55
Drop unused webrick development dependency
robzolkos Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ jobs:
with:
go-version-file: 'go/go.mod'
cache-dependency-path: 'go/go.sum'
# Scan against the newest 1.26.x, not whatever patch the runner has cached.
check-latest: true

- name: Install govulncheck
run: go install golang.org/x/vuln/cmd/govulncheck@latest
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,22 @@ jobs:
persist-credentials: false

- name: Set up Ruby
if: matrix.ruby != 'head'
uses: ruby/setup-ruby@7372622e62b60b3cb750dcd2b9e32c247ffec26a # v1.302.0
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
working-directory: ruby

- name: Set up Ruby head
if: matrix.ruby == 'head'
uses: ruby/setup-ruby@7372622e62b60b3cb750dcd2b9e32c247ffec26a # v1.302.0
with:
ruby-version: ${{ matrix.ruby }}
bundler: default
bundler-cache: true
working-directory: ruby

- name: Lint
if: matrix.ruby == '3.3'
run: bundle exec rubocop
Expand Down
3 changes: 0 additions & 3 deletions ruby/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ GEM
addressable (>= 2.8.0)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
webrick (1.9.2)
yard (0.9.44)
zeitwerk (2.8.2)

Expand All @@ -153,7 +152,6 @@ DEPENDENCIES
rubocop-37signals
simplecov (~> 0.22)
webmock (~> 3.24)
webrick (~> 1.9)
yard (~> 0.9)

CHECKSUMS
Expand Down Expand Up @@ -216,7 +214,6 @@ CHECKSUMS
unicode-emoji (4.2.0) sha256=519e69150f75652e40bf736106cfbc8f0f73aa3fb6a65afe62fefa7f80b0f80f
uri (1.1.1) sha256=379fa58d27ffb1387eaada68c749d1426738bd0f654d812fcc07e7568f5c57c6
webmock (3.26.2) sha256=774556f2ea6371846cca68c01769b2eac0d134492d21f6d0ab5dd643965a4c90
webrick (1.9.2) sha256=beb4a15fc474defed24a3bda4ffd88a490d517c9e4e6118c3edce59e45864131
yard (0.9.44) sha256=eb087e9b631ccd887b049f303d489963945452d5e2a7eb49a5a74a7cf6887f28
zeitwerk (2.8.2) sha256=7212a61311083c604184b1ea2574b9aa05cd14f855a0841c06985cabe9181d12

Expand Down
1 change: 0 additions & 1 deletion ruby/basecamp-sdk.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,5 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'webmock', '~> 3.24'
spec.add_development_dependency 'irb', '~> 1.15'
spec.add_development_dependency 'rdoc', '~> 7.1'
spec.add_development_dependency 'webrick', '~> 1.9'
spec.add_development_dependency 'yard', '~> 0.9'
end
Loading