Custom nitro enclave verifier contract#203
Draft
roger-bai-coinbase wants to merge 146 commits intomainfrom
Draft
Custom nitro enclave verifier contract#203roger-bai-coinbase wants to merge 146 commits intomainfrom
roger-bai-coinbase wants to merge 146 commits intomainfrom
Conversation
…andling into a single function, improving code clarity and maintainability. Update tests accordingly to reflect the new verification structure.
…onventions for clarity in Nullify tests.
…ild game in AggregateVerifier. Implement corresponding test case to verify this behavior.
…d rollup configuration. Update verification methods to use a journal hash instead of root claims. Modify MockVerifier and tests accordingly.
…date validation check to use this constant
…ier, updating documentation and logic to clarify its purpose as the L2 sequence number.
…rnal to public, enhancing accessibility for contract interactions.
…fier to emit event upon credit transfer
…er for consistency with internal function naming conventions.
…nsolidating the return statement for the first dispute game scenario.
…-basecontracts' into feat/switch-nitro-certificate-verification-to-zk
…figgloabal initialize
…-basecontracts' into feat/switch-nitro-certificate-verification-to-zk
…-basecontracts' into feat/switch-nitro-certificate-verification-to-zk
…-basecontracts' into feat/switch-nitro-certificate-verification-to-zk
…eploy config, and parameterize hardcoded l2ChainID/block intervals in DeployImplementations
…heck correct version() number
* use a proof threshold and allow ZK proofs after TEE nullification * pr feedback * update deployment scripts and tests * allow tee nullfiication when a zk proof exists. extend timestamp in this case to allow for zk nullification
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a custom version of Automata's NitroEnclaveVerifier contract
proofSubmitterrole that is owner controlled