Skip to content

fix: add missing args parameter to setImplementation in dev deploy scripts#202

Merged
leopoldjoy merged 1 commit intomainfrom
fix/setImplementation-calls-in-deploy-scripts-corrections
Mar 7, 2026
Merged

fix: add missing args parameter to setImplementation in dev deploy scripts#202
leopoldjoy merged 1 commit intomainfrom
fix/setImplementation-calls-in-deploy-scripts-corrections

Conversation

@leopoldjoy
Copy link
Contributor

Summary

  • Fix setImplementation calls in DeployDevNoNitro.s.sol and DeployDevWithNitro.s.sol to pass the third bytes calldata _args parameter added by a recent merge. Without this, the scripts fail with encode length mismatch: expected 0 types, got 1.

Changes

  • scripts/multiproof/DeployDevNoNitro.s.sol: Add empty bytes "" as third arg to setImplementation.
  • scripts/multiproof/DeployDevWithNitro.s.sol: Same fix.

Test plan

  • forge build compiles successfully
  • forge fmt --check clean

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 7, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@leopoldjoy leopoldjoy merged commit a176098 into main Mar 7, 2026
8 checks passed
@leopoldjoy leopoldjoy deleted the fix/setImplementation-calls-in-deploy-scripts-corrections branch March 7, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants