Stdout tests#47
Open
beykyle wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
Running with mpi n>1 leads to cross sections different by up to 1e-5 rtol and 2e-1 atol. This is confirmed to be behavior of frescox as run by hand, not bfrescox. tols in test harness adjusted accordingly. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 78.81% 76.13% -2.68%
==========================================
Files 35 36 +1
Lines 1213 1366 +153
==========================================
+ Hits 956 1040 +84
- Misses 257 326 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Looks like there's an issue across pandas versions. Best solution is probably to stop using pickles for test refs |
Merged
Collaborator
Author
|
Seems like stdout parsing is flaky for older mac OS, likely due to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds testing for frescox stdout, comparing cross sections parsed from stdout produced in tests to reference stdout for the test inputs.
Depends on #19, should be reviewed after that has been merged.