Skip to content

Stdout tests#47

Open
beykyle wants to merge 5 commits into
mainfrom
stdout-tests
Open

Stdout tests#47
beykyle wants to merge 5 commits into
mainfrom
stdout-tests

Conversation

@beykyle
Copy link
Copy Markdown
Collaborator

@beykyle beykyle commented May 30, 2026

Adds testing for frescox stdout, comparing cross sections parsed from stdout produced in tests to reference stdout for the test inputs.

Depends on #19, should be reviewed after that has been merged.

@beykyle
Copy link
Copy Markdown
Collaborator Author

beykyle commented May 30, 2026

Running with mpi n>1 leads to cross sections different by up to 1e-5 rtol and 2e-1 atol. This is confirmed to be behavior of frescox as run by hand, not bfrescox. tols in test harness adjusted accordingly.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 30, 2026

Codecov Report

❌ Patch coverage is 53.80117% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.13%. Comparing base (e298d3d) to head (cf6dffa).

Files with missing lines Patch % Lines
common/_parse_differential_xs.py 52.83% 25 Missing ⚠️
...escox_pypkg/src/bfrescox/tests/TestElasticSuite.py 60.86% 9 Missing ⚠️
...cox_pypkg/src/bfrescox/tests/TestInelasticSuite.py 50.00% 9 Missing ⚠️
...src/bfrescox/tests/TestRunUserProvidedTemplates.py 50.00% 9 Missing ⚠️
...ro_pypkg/src/bfrescoxpro/tests/TestElasticSuite.py 60.86% 9 Missing ⚠️
..._pypkg/src/bfrescoxpro/tests/TestInelasticSuite.py 50.00% 9 Missing ⚠️
.../bfrescoxpro/tests/TestRunUserProvidedTemplates.py 50.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   78.81%   76.13%   -2.68%     
==========================================
  Files          35       36       +1     
  Lines        1213     1366     +153     
==========================================
+ Hits          956     1040      +84     
- Misses        257      326      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beykyle
Copy link
Copy Markdown
Collaborator Author

beykyle commented May 30, 2026

Looks like there's an issue across pandas versions. Best solution is probably to stop using pickles for test refs

@beykyle beykyle mentioned this pull request May 30, 2026
@beykyle beykyle mentioned this pull request Jun 2, 2026
14 tasks
@beykyle
Copy link
Copy Markdown
Collaborator Author

beykyle commented Jun 2, 2026

Seems like stdout parsing is flaky for older mac OS, likely due to the \R character in the output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants