Skip to content

Use groupId for bare consumers instead of KStreams appId #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkbe merged 1 commit into from
Mar 12, 2026
Merged

Use groupId for bare consumers instead of KStreams appId #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...otstrap-cli/src/test/java/com/bakdata/kafka/consumer/KafkaConsumerApplicationCliTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* MIT License
*
* Copyright (c) 2025 bakdata
* Copyright (c) 2026 bakdata
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -155,7 +155,7 @@ public DeserializerConfig defaultSerializationConfig() {

@Test
@ExpectSystemExitWithStatus(1)
void shouldExitWithErrorCodeOnInconsistentAppId() {
void shouldExitWithErrorCodeOnInconsistentGroupId() {
new KafkaConsumerApplication<>() {
@Override
public ConsumerApp createApp() {
Expand Down
2 changes: 1 addition & 1 deletion ...test/java/com/bakdata/kafka/consumerproducer/KafkaConsumerProducerApplicationCliTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public void run() {

@Test
@ExpectSystemExitWithStatus(1)
void shouldExitWithErrorCodeOnInconsistentAppId() {
void shouldExitWithErrorCodeOnInconsistentGroupId() {
new KafkaConsumerProducerApplication<>() {
@Override
public ConsumerProducerApp createApp() {
Expand Down
6 changes: 3 additions & 3 deletions ...re/src/main/java/com/bakdata/kafka/consumerproducer/ConsumerProducerAppConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ public class ConsumerProducerAppConfiguration {

@Getter
private final @NonNull ConsumerProducerTopicConfig topics;
private final String uniqueAppId;
private final String uniqueGroupId;

/**
* Create a new {@code ConsumerProducerAppConfiguration} with no provided {@link #uniqueAppId}
* Create a new {@code ConsumerProducerAppConfiguration} with no provided {@link #uniqueGroupId}
*
* @param topics topics to use for app
*/
Expand All @@ -55,6 +55,6 @@ public ConsumerProducerAppConfiguration(final ConsumerProducerTopicConfig topics
* @see ConsumerProducerApp#getUniqueGroupId(ConsumerProducerAppConfiguration)
*/
public Optional<String> getUniqueGroupId() {
return Optional.ofNullable(this.uniqueAppId);
return Optional.ofNullable(this.uniqueGroupId);
}
}
8 changes: 4 additions & 4 deletions ...ms-bootstrap-core/src/test/java/com/bakdata/kafka/consumer/ConfiguredConsumerAppTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* MIT License
*
* Copyright (c) 2025 bakdata
* Copyright (c) 2026 bakdata
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -141,7 +141,7 @@ void shouldThrowIfSchemaRegistryHasBeenConfiguredDifferently() {
}

@Test
void shouldThrowIfAppIdIsInconsistent() {
void shouldThrowIfGroupIdIsInconsistent() {
final ConfiguredConsumerApp<ConsumerApp> configuredApp = new ConfiguredConsumerApp<>(new ConsumerApp() {
@Override
public ConsumerRunnable buildRunnable(final ConsumerBuilder builder) {
Expand All @@ -164,7 +164,7 @@ public String getUniqueGroupId(final ConsumerAppConfiguration configuration) {
}

@Test
void shouldThrowIfAppIdIsNull() {
void shouldThrowIfGroupIdIsNull() {
final ConfiguredConsumerApp<ConsumerApp> configuredApp = new ConfiguredConsumerApp<>(new ConsumerApp() {
@Override
public ConsumerRunnable buildRunnable(final ConsumerBuilder builder) {
Expand All @@ -187,7 +187,7 @@ public String getUniqueGroupId(final ConsumerAppConfiguration configuration) {
}

@Test
void shouldReturnConfiguredAppId() {
void shouldReturnConfiguredGroupId() {
final ConfiguredConsumerApp<ConsumerApp> configuredApp = new ConfiguredConsumerApp<>(new ConsumerApp() {
@Override
public ConsumerRunnable buildRunnable(final ConsumerBuilder builder) {
Expand Down
2 changes: 1 addition & 1 deletion ...e/src/test/java/com/bakdata/kafka/consumerproducer/ConfiguredConsumerProducerAppTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ void shouldThrowIfValueSerdeHasBeenConfiguredDifferently() {
}

@Test
void shouldThrowIfAppIdHasBeenConfiguredDifferently() {
void shouldThrowIfGroupIdHasBeenConfiguredDifferently() {
final ConfiguredConsumerProducerApp<ConsumerProducerApp> configuredApp =
new ConfiguredConsumerProducerApp<>(new TestApplication(), emptyTopicConfig());
final RuntimeConfiguration runtimeConfiguration = RuntimeConfiguration.create("fake")
Expand Down
Loading