Clean up Consumer/ConsumerProducer#421
Merged
philipp94831 merged 17 commits intomasterfrom Mar 9, 2026
Merged
Conversation
philipp94831
commented
Feb 26, 2026
...ams-bootstrap-core/src/main/java/com/bakdata/kafka/consumerproducer/ConsumerProducerApp.java
Outdated
Show resolved
Hide resolved
philipp94831
commented
Feb 26, 2026
...p-core/src/main/java/com/bakdata/kafka/consumerproducer/DefaultConsumerProducerRunnable.java
Outdated
Show resolved
Hide resolved
...p-core/src/main/java/com/bakdata/kafka/consumerproducer/DefaultConsumerProducerRunnable.java
Outdated
Show resolved
Hide resolved
streams-bootstrap-core/src/main/java/com/bakdata/kafka/consumer/DefaultConsumerRunnable.java
Outdated
Show resolved
Hide resolved
philipp94831
commented
Feb 26, 2026
streams-bootstrap-core/src/main/java/com/bakdata/kafka/consumer/ConsumerRunner.java
Outdated
Show resolved
Hide resolved
jkbe
previously approved these changes
Mar 9, 2026
streams-bootstrap-cli/src/main/java/com/bakdata/kafka/mixin/ConsumerOptions.java
Show resolved
Hide resolved
streams-bootstrap-core/src/main/java/com/bakdata/kafka/CloseExecutionOptions.java
Outdated
Show resolved
Hide resolved
…ecutionOptions.java Co-authored-by: Jakob Edding <15202881+jkbe@users.noreply.github.com>
jkbe
approved these changes
Mar 9, 2026
|
raphala
approved these changes
Mar 9, 2026
jkbe
added a commit
that referenced
this pull request
Mar 11, 2026
jkbe
added a commit
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #385 and #387