feat(review): add Cmd/Ctrl+Shift+Y shortcut to copy feedback - #1155
Draft
rian-dolphin wants to merge 1 commit into
Draft
feat(review): add Cmd/Ctrl+Shift+Y shortcut to copy feedback#1155rian-dolphin wants to merge 1 commit into
rian-dolphin wants to merge 1 commit into
Conversation
rian-dolphin
force-pushed
the
feat/copy-feedback-shortcut
branch
from
July 30, 2026 12:42
5a0e5a9 to
36037e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a keyboard shortcut to the code review UI. The shortcut is
Cmd/Ctrl+Shift+Y. The shortcut copies the review feedback to the clipboard.Before this change, the user must click two controls. First, the user clicks the comment icon in the header. Then the user clicks the Copy Feedback button.
Method
The
handleCopyFeedbackcallback is available already inApp.tsx. A new effect connects the keys to that callback. The effect uses the same guards as theCmd/Ctrl+Entereffect:A new entry in
packages/review-editor/shortcuts.tsdeclares the shortcut. Thus the Settings list shows the shortcut automatically.Key selection
Mod+Shift+Yis free in the code review registry.Mod+Shift+Cis not free, because the browser uses those keys for the developer tools. Tell me if you prefer different keys or push a commit to update etc.Tests
bun testgives 2440 pass and 22 fail. The same 22 tests also fail onmain. Thus these failures are not related to this change.