fix(ui): focus and select existing review search text - #1152
Merged
backnotprop merged 1 commit intoJul 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
A common workflow while reviewing a diff is:
The first search works naturally because the search field starts empty. After that, the previous query remains in the
field. When Cmd/Ctrl+F is used again, the caret is at the end of the existing query, instead of selecting the entire text. Pasting another symbol can therefore append it to the previous query instead of replacing it.
See example below:
Expected behavior
Reopening search with Cmd/Ctrl+F should select the existing query so the next typed or pasted symbol replaces it immediately. Browsers, editors, IDEs, etc. do this.
Changes
Scope
This does not change search matching, indexing, result navigation, or shortcut availability. Existing guards for views without review search remain unchanged.
Testing
DOM_TESTS=1 bun test packages/review-editor/hooks/useReviewSearch.test.tsx