Repository navigation
perf: 絵文字辞書をstaticに保持して再利用する - #378
Merged
Merged
Conversation
ensan-hcl
marked this pull request as ready for review
September 27, 2026 01:31
ensan-hcl
self-requested a review
September 27, 2026 01:31
Contributor
Author
|
discordに書いていた内容をこちらにも転記しておきます📝 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容
変換の候補更新のたびにTextReplacer.withDefaultEmojiDictionary()を呼び絵文字辞書を読み込み・再構築していたため、static letで保持して再利用するように修正しました
絵文字辞書は同梱の静的データで、変換結果による更新処理はないため、初回のみ初期化すれば良いと考えています
確認事項
以下が成功することを確認しています