Skip to content

fix: Sanitize folder paths in terminal sendText to prevent command Injection - #190

Merged
azmkercso merged 2 commits into
aws:1.1from
aakashmandavilli96:1.1
Apr 16, 2026
Merged

azmkercso merged 2 commits into
aws:1.1from
aakashmandavilli96:1.1

Conversation

@aakashmandavilli96

Copy link
Copy Markdown
Contributor

Issue

  • P381721885

Description of Changes

  • Sanitize folder paths

Testing

  • Need to build the image locally and test the change

Screenshots/Videos

  • NA

Additional Notes

  • NA

Backporting

  • NA

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aakashmandavilli96
aakashmandavilli96 requested review from a team as code owners April 10, 2026 22:27
ghost
ghost previously approved these changes Apr 10, 2026

@ghost ghost left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, otherwise LGTM

Comment thread patches/sagemaker/sanitize-terminal-sendtext-paths.diff
sachinh-amazon
sachinh-amazon previously approved these changes Apr 13, 2026
azmkercso
azmkercso previously approved these changes Apr 14, 2026
@aakashmandavilli96
aakashmandavilli96 dismissed stale reviews from azmkercso, sachinh-amazon, and ghost via e62e552 April 15, 2026 16:20
@azmkercso
azmkercso merged commit b8e2b1f into aws:1.1 Apr 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants