Fix Windows OPENSSL_SMALL Debug builds with NASM 2.16.01 - #3420
Merged
Merged
Conversation
Emit a byte when AVX-512 assembly is disabled so NASM 2.16.01 does not crash while generating CodeView information for an empty section. Pin NASM 2.16.01 and run the pre-generated OPENSSL_SMALL Windows CI leg in Debug mode to cover the failure.
Contributor
|
🔒 Security Review — View Report Please review before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3420 +/- ##
=======================================
Coverage 78.20% 78.21%
=======================================
Files 695 695
Lines 124271 124282 +11
Branches 17265 17267 +2
=======================================
+ Hits 97186 97205 +19
+ Misses 26161 26155 -6
+ Partials 924 922 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
geedo0
approved these changes
Aug 14, 2026
sgmenda
approved these changes
Aug 17, 2026
| - name: Install NASM | ||
| uses: ilammy/setup-nasm@v1.5.1 | ||
| with: | ||
| version: "2.16.01" |
Contributor
There was a problem hiding this comment.
do we wanna globally fix the nasm version? versus test this and other versions customers use?
| - { name: "pre-generated", disable_perl: "ON", disable_avx: "OFF" } | ||
| - { name: "perlasm, AVX disabled", disable_perl: "OFF", disable_avx: "ON" } | ||
| - { name: "perlasm", build_type: "Release", disable_perl: "OFF", disable_avx: "OFF" } | ||
| - { name: "pre-generated, Debug", build_type: "Debug", disable_perl: "ON", disable_avx: "OFF" } |
Contributor
There was a problem hiding this comment.
do we wanna also test pre-generated, Release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
NASM 2.16.01 can crash while generating CodeView debug information for empty text sections produced when AVX-512 assembly is disabled in
OPENSSL_SMALLbuilds. Emit an unreferenced byte in the affected disabled assembly sources so the section is non-empty, and update CI to reproduce the failure using NASM 2.16.01 with a Windows Debug build.Call-outs:
The byte is emitted only when
MY_ASSEMBLER_IS_TOO_OLD_FOR_512AVXdisables the corresponding AVX-512 implementation.Testing:
OPENSSL_SMALLDebug configuration.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.