You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR only touches .github/workflows/ai-pr-review.yml, updating the pinned commit SHA for the reusable aws/aws-durable-execution-ci/.github/workflows/ai-pr-review.yml workflow (to the stated v0.3.1 commit) and adding run-claude: false. It contains no changes to SDK source (sdk/, sdk-testing/, sdk-integration-tests/, otel-plugin/, examples/), so none of the checkpoint-and-replay, retry/callback/invoke, concurrency, serialization, or plugin-lifecycle concerns this review focuses on are implicated.
Observations:
The YAML edit is syntactically valid: the new run-claude: false key is properly indented under the existing with: block, and the changed uses: line still references a 40‑character hex SHA in the correct owner/repo/.github/workflows/file.yml@sha format.
Pinning to a full commit SHA (rather than a mutable tag) is the safer practice for a pull_request_target workflow that carries contents: write, id-token: write, and pull-requests: write permissions, and setting run-claude: false matches the stated intent of keeping Claude-based review disabled.
No test changes accompany this PR, which is appropriate per AGENTS.md/CONTRIBUTING.md since this is workflow-configuration-only and not testable application logic.
Residual risk (not verifiable from this sandbox, no network access): I cannot confirm that d6b017da14385908951d23e26c790b28a4e5f9f0 is actually the commit tagged v0.3.1 in aws/aws-durable-execution-ci, nor that the reusable workflow at that commit accepts a run-claude input. Given this workflow runs with elevated permissions on pull_request_target, it's worth a manual/out-of-band check (e.g., comparing the SHA against the v0.3.1 tag in that repo) before merging, but this is an operational verification step rather than a code defect I can confirm or refute here.
No functional or correctness findings to report.
Reviewed commit 5e7702e509f71cdd827928247d0e8327b9b71027. Workflow run
No actionable findings. Residual risk is limited to compatibility with the external reusable workflow at the newly pinned SHA, whose implementation is not present in this checkout.
Reviewed commit 5e7702e509f71cdd827928247d0e8327b9b71027. Workflow run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
N/A
Description
d6b017da14385908951d23e26c790b28a4e5f9f0(v0.3.1).run-claude: falseso Claude AI review remains disabled.Demo/Screenshots
N/A
Checklist
Testing
Unit Tests
Not applicable; this only updates workflow configuration.
Integration Tests
Not applicable; the workflow YAML parses successfully and
git diff --checkpasses.Examples
Not applicable.