Skip to content

fix(insight): make remote exporters optional #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyb-A wants to merge 1 commit into from
+27 −334
Closed

fix(insight): make remote exporters optional #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions insight-plugin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,27 @@ CloudWatch), `S3Exporter` (canonical `operations` array, one object per executio
`CloudWatchLogsExporter` (PutLogEvents to a specific log group, `operationsByName` map). Implement
`InsightExporter` for custom sinks.

`LambdaLogExporter` needs no extra dependency. The AWS SDK service modules used by the remote
exporters are optional so applications that use only Lambda logs do not package them. Add the module
for each remote exporter you configure, using the AWS SDK for Java 2.x version managed by your
application:

```xml
<!-- Required only for S3Exporter -->
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>s3</artifactId>
<version>AWS_SDK_VERSION</version>
</dependency>

<!-- Required only for CloudWatchLogsExporter -->
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>cloudwatchlogs</artifactId>
<version>AWS_SDK_VERSION</version>
</dependency>
```

## Design

- **Snapshot-based, not accumulated.** Each record is built directly from the current-invocation
Expand All @@ -39,10 +60,10 @@ CloudWatch), `S3Exporter` (canonical `operations` array, one object per executio
`InvocationInfo.executionInput()` / `InvocationEndInfo.executionResult()`, and per-operation
results from `OperationChangeItemInfo.result()` (all surfaced by SDK PR #618). There is no global
"current ARN" or cross-hook operation accumulation.
- **Per-execution state keyed by execution ARN** holds only the stable start time, parsed ARN,
cached input, and the one-time deterministic sampling decision. State is **preserved across
non-terminal (PENDING/RETRYING) invocations** so suspend/resume keeps a single stable start time
and correct duration, and is removed **only** once the execution is terminal.
- **Per-execution state keyed by execution ARN** holds the stable start time, parsed ARN, cached
input, and deterministic sampling decision for the current invocation. State is removed after
every invocation end, including PENDING/RETRYING, and recreated from stable hook data when the
execution resumes.
- **Deterministic sampling.** FNV-1a-32 over the execution ARN mapped into `[0,1)`, identical to
the JS implementation, so a resumed execution always reaches the same in/out decision.
- **Emission modes.** `ON_COMPLETE` emits one terminal record; `ON_FAILURE` emits only on terminal
Expand Down
Loading