Skip to content

fix(insight): make remote exporters optional - #695

Closed
wangyb-A wants to merge 1 commit into
workflow-insight-pluginfrom
workflow-insight-dependency-doc-fixes
Closed

wangyb-A wants to merge 1 commit into
workflow-insight-pluginfrom
workflow-insight-dependency-doc-fixes

Conversation

@wangyb-A

@wangyb-A wangyb-A commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue Link, if available

Stacked on #661.

Addresses items 1–3 from #661 (comment). The ON_CHANGE design question remains outside this PR.

Description

Customers who use the default LambdaLogExporter should not package the S3 and CloudWatch Logs service clients. This PR marks those two Maven dependencies optional and documents the dependencies required by each remote exporter.

It also removes the internal AI review ledger from the public branch and updates the state-lifecycle documentation to match the implementation: invocation state is removed after every invocation end and recreated from stable hook data on resume.

Demo/Screenshots

Not applicable. This PR changes Maven metadata and documentation only.

Checklist

  • I have filled out every section of the PR template
  • I have thoroughly tested this change

Testing

  • git diff --check
  • mvn -B -q spotless:check --file pom.xml
  • mvn -q -pl insight-plugin -am clean verify
  • Installed the plugin locally and resolved it from an isolated consumer POM. The consumer dependency tree includes jackson-datatype-jsr310 but excludes software.amazon.awssdk:s3 and software.amazon.awssdk:cloudwatchlogs.
  • mvn -q clean verify was attempted twice. Both runs reached the unchanged otel-plugin module and failed only at InvocationOtelPluginTest.invocationEnd_closesNestedSpansChildFirst; that test passes when rerun in isolation. This PR does not change OpenTelemetry code or dependencies.

Unit Tests

No new unit tests. The behavior change is Maven transitive-dependency metadata and was verified with an isolated consumer dependency tree.

Integration Tests

No new integration tests. Existing insight-plugin tests pass through the targeted reactor build.

Examples

No new example is needed for this metadata and documentation correction.

Keep S3 and CloudWatch Logs clients out of default consumer dependency trees, document opt-in dependencies, remove the internal review ledger, and align lifecycle documentation with implementation.
@wangyb-A

wangyb-A commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Intent: Keep optional remote exporter clients out of default consumer packages and remove stale/internal documentation from the Workflow Insight change.
Not a goal: This PR does not redesign ON_CHANGE export scheduling or change runtime record behavior.

@wangyb-A wangyb-A mentioned this pull request Sep 9, 2026
2 tasks
@wangyb-A
wangyb-A added this pull request to stack #696 September 9, 2026 18:35
@wangyb-A wangyb-A closed this Sep 9, 2026
@wangyb-A
wangyb-A removed this pull request from stack #696 September 9, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant