feat(cli): synth prints validation report#1633
Open
kaizencc wants to merge 1 commit into
Open
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1633 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 77 77
Lines 11359 11359
Branches 1584 1584
=======================================
Hits 10079 10079
Misses 1250 1250
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now,
cdk synthrelies on the legacy pretty-printed report written by the validation plugin logic inaws/aws-cdk. This PR aims to replace that with the modern report thatcdk validateuses. A subsequent PR will be made to remove the legacy report stlye fromaws/aws-cdk.The new model is:
validation-report.jsonartifact detailing all validation mechanisms in one place. It does not handle printing anymore.validation-report.jsonand bothcdk synthandcdk validatewrites the same style report to the console.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license