feat(eval): online-insight TUI get/list + #2029 insights column (P4) - #2072
Open
jariy17 wants to merge 1 commit into
Open
feat(eval): online-insight TUI get/list + #2029 insights column (P4)#2072jariy17 wants to merge 1 commit into
jariy17 wants to merge 1 commit into
Conversation
jariy17
marked this pull request as ready for review
August 22, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P4 — online-insight read-only TUI + #2029 insights column
Stacked on #2070 (base branch
feat/online-eval-byo-role, P3). Read-only TUI only — no deploy/mutation paths.New screens (
src/handlers/eval/online-insight/)screen.tsx—OnlineInsightScreen(RouterScreen path["agentcore","eval","online-insight"]).list/screen.tsx—OnlineInsightListScreen; reusesOnlineEvalPicker, reads viacore.eval.listOnlineInsights.get/screen.tsx—OnlineInsightGetScreen+OnlineInsightGetJsonScreenviacore.eval.getOnlineInsight. Detail shows insight count + clustering frequencies instead of the evaluator count.Router + routes
online-insight/index.tsx: added.use(withTuiOnEmptyFlagsAndArgs),.default(renderTui),.supportedTuiCommands("get","list"), andexport { OnlineInsightScreen }.Root.tsx: added the 5 online-insight routes mirroring online-eval (menu · list ·get→list redirect ·get/:configId·get/:configId/json) and the screen imports.#2029 — insights indicator column
Issue #2029: "online-eval imperative TUI table should include an 'insights' field that indicates whether that online eval has insights enabled."
has-insightscolumn to the online-eval list table (and the online-insight list, same picker). Value =config.insights?.length > 0, renderedyes/-. Sourced fromOnlineEvaluationConfigSummary.insightson the list summary — no extra API call.Picker: parameterized, not forked
OnlineEvalPickergained optionalresourceLabel,queryKey, andloadPageprops (defaulting to the online-eval behavior) so the online-insight list reuses the same component and columns. Columns/toRoware shared (identical for both lists) with the insights column baked into the defaultonlineEvalColumns, so no fork and no dead per-list column overrides.Tests
online-insight.screen.test.tsxmirroring the online-eval screen test: menu (read-only commands only), picker (insights columnyes/-,listOnlineInsightsargs, bare-getredirect, selection → detail, empty state), detail (sampling / execution / insight count / clustering frequencies,getOnlineInsightargs, JSON view, retry).online-eval.screen.test.tsx.bun test src/handlers/eval/online-insight+online-eval: 64 pass. Broaderbun test src/components src/handlers/eval: 319 pass.tsc --noEmit: clean.