feat: add imperative batch-insights command - #2066
Open
nborges-aws wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
agentcore-harness-reviewing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2066 +/- ##
============================================
+ Coverage 97.15% 97.24% +0.08%
============================================
Files 387 392 +5
Lines 23142 23266 +124
============================================
+ Hits 22483 22624 +141
+ Misses 659 642 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jariy17
requested changes
Aug 21, 2026
jariy17
left a comment
jariy17
left a comment
Contributor
There was a problem hiding this comment.
Left some comments. Pretty good thou
| import { EvalClient } from "./eval"; | ||
| import type { AwsClients } from "./types"; | ||
|
|
||
| describe("EvalClient.startBatchInsights", () => { |
Contributor
There was a problem hiding this comment.
We don't need this unit test. This should be captured by handler unit tests
| z.string().optional(), | ||
| ), | ||
| flag( | ||
| "online-eval", |
Contributor
There was a problem hiding this comment.
Can you use online-eval as a data source for batch insight?
| import { parseJsonFlag } from "../utils"; | ||
| import type { SessionSourceValue, SessionWindow } from "./types"; | ||
|
|
||
| export const sessionSourceFlags = [ |
Contributor
There was a problem hiding this comment.
Encapsulate this as a class please :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds imperative batch insights commands for AgentCore evaluations:
Summary of changes
--insightdefaults toBuiltin.Insight.FailureAnalysissessionSourceutilityType of Change
Testing
Added unit tests along with golden fixture tests (recorded against team AWS account). Also ran manual smoke tests against runtime invocations in my personal account, succeeding on all three added commands.
Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬