Skip to content

Conversation

@patrickkang
Copy link
Contributor

@patrickkang patrickkang commented Oct 6, 2025

Changes

Removing redundant requirements.txt since poetry is used: https://github.com/auth0/auth0-api-python/blob/main/CONTRIBUTING.md

Checklist

@patrickkang patrickkang marked this pull request as ready for review October 6, 2025 20:16
@patrickkang patrickkang requested a review from a team as a code owner October 6, 2025 20:16
Copy link
Contributor

@kishore7snehil kishore7snehil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickkang May I know the reason for removal of this file?

@patrickkang
Copy link
Contributor Author

@kishore7snehil Seems redundant to me since it looks like we are using poetry. Why do we need to use both poetry AND requirements.txt?

@kishore7snehil
Copy link
Contributor

kishore7snehil commented Oct 8, 2025

@patrickkang While I understand the concern about redundancy, requirements.txt serves a specific purpose beyond development dependency management Our Snyk security scanning relies on requirements.txt to identify and scan dependencies. Removing it will break our security checks. Also, it is common to maintain both (as an industry best practice).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants