refactor: share placeholder-aware prompt refinement extraction - #6802
Merged
Conversation
atomantic
force-pushed
the
claim/issue-6794
branch
from
September 10, 2026 04:40
5aa6592 to
f17fba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media and Universe Builder prompt refinement now share the same placeholder-aware JSON extractor. Both retain the existing fence handling, repair passes, and distinct placeholder-only and parse failures; the general extractJson fallback behavior is unchanged.
Moved the existing refinement parser cases into the shared library suite. Existing media workflow tests still cover schema echoes and placeholder rejection.
Validation: 103 tests passed across jsonExtract, universeBuilderRefine, and mediaPromptRefiner.
Review: self-review complete. Configured optional reviewer opencode
optmax=1 was unavailable because the generic CLI has no maintained enforced public-content sandbox; no unrestricted reviewer was run.Closes #6794