This repository was archived by the owner on Dec 15, 2022. It is now read-only.
change xcode_settings in binding.gyp for universal macOs build#415
Open
poisonReact wants to merge 1 commit intoatom:masterfrom
Open
change xcode_settings in binding.gyp for universal macOs build#415poisonReact wants to merge 1 commit intoatom:masterfrom
poisonReact wants to merge 1 commit intoatom:masterfrom
Conversation
|
Recommend against this, this will double the binary size. I have two separate builds for x64 and arm64 and only include the .node for the target arch. |
Author
we are specially build a universal version for macOs application so as not to confuse users |
|
Looking forward to this one! |
|
Only way for us to use keytar on a universal build was to use this pull request in combination with buildDependenciesFromSource in the electron-builder file Using the prebuilt adds a keytar.node to the asar file that is not universal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍎