Address issue where dictionary size changed during iteration

[cthoyt]

I did some initial exploring and figured out that a size changed during iteration error got triggered for a names dictionary corresponding to a Pydantic model, but in my case (cthoyt/sssom-pydantic#171) it's happening for a model that my code changes don't touch

this fix at least makes sure that the size doesn't change during iteration, but there might be something deeper going on

---

🫀 No generative artificial intelligence was used to produce the code and text for this contribution; only human intelligence

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.50%. Comparing base (22afea1) to head (136b892).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
sphinx_automodapi/automodsumm.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files          31       31           
  Lines        1258     1258           
=======================================
  Hits         1126     1126           
  Misses        132      132           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bsipocz]

Thanks! It looks good, but I would do the list conversion on a different line instead.

[cthoyt]

@bsipocz thanks for the feedback. The suggestions got messy so I threw out those commits and made a new one that cleans it all up

[cthoyt]

Interestingly, dir() explicitly is type annotated by the standard library to return list[str], so I just took that part out.

[bsipocz]

Thanks!

[pllim]

Thanks, all! Do we need an immediate release?

[cthoyt]

I would appreciate a timely release, but not "drop everything you're doing" immediate. Cheers :)

[bsipocz]

Thanks, all! Do we need an immediate release?

There is nothing else in the diff, are we waiting for anything else? E.g. I would love to have this closed before we tag a new release: #234

[pllim]

I don't have time to dig into #234 . I think it is reasonable to have bugfix release with just one patch if actual users are affected?

[bsipocz]

OK, let me wait until the end of the week, maybe I'll have some time to look into this and upstream sphinx.

[pllim]

Thank you! 🙏 🙇‍♀️

[pllim]

@bsipocz , should I go ahead with the release? Please advise. Thanks!