Skip to content

Validate hour range for PM meridian like AM #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IgnazioDS wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

Validate hour range for PM meridian like AM #1296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions arrow/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,10 @@ def _parse_token(
)
elif value in (self.locale.meridians["pm"], self.locale.meridians["PM"]):
parts["am_pm"] = "pm"
if "hour" in parts and not 0 <= parts["hour"] <= 12:
raise ParserMatchError(
f"Hour token value must be between 0 and 12 inclusive for token {token!r}."
)
elif token == "W":
parts["weekdate"] = value

Expand Down
5 changes: 5 additions & 0 deletions tests/test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,11 @@ def test_parse_am(self):
with pytest.raises(ParserMatchError):
self.parser.parse("2021-01-30 14:00:00 AM", "YYYY-MM-DD HH:mm:ss A")

def test_parse_pm_invalid_hour(self):
# A PM meridian must reject out-of-range hours just like AM does.
with pytest.raises(ParserMatchError):
self.parser.parse("2021-01-30 14:00:00 PM", "YYYY-MM-DD HH:mm:ss A")

def test_parse_year_two_digit(self):
self.expected = datetime(1979, 1, 1, 12, 5, 10)
assert (
Expand Down
Loading