Fix arrow.get() crash when tzinfo=None is explicitly passed#1260
Open
rexkirshner wants to merge 1 commit intoarrow-py:masterfrom
Open
Fix arrow.get() crash when tzinfo=None is explicitly passed#1260rexkirshner wants to merge 1 commit intoarrow-py:masterfrom
rexkirshner wants to merge 1 commit intoarrow-py:masterfrom
Conversation
The condition for detecting non-tzinfo kwargs checked `tz is None`
instead of whether 'tzinfo' was actually absent from kwargs. This
caused `arrow.get('2025-01-01', 'YYYY-MM-DD', tzinfo=None)` to
incorrectly bump arg_count to 3, falling through to the constructor
path and raising TypeError.
Fixes arrow-py#1259
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1260 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1259
arrow.get('2025-01-01', 'YYYY-MM-DD', tzinfo=None)raisesTypeErrorbecause the factory's kwarg-detection logic treats an explicittzinfo=Nonethe same as an unrelated constructor kwarg (likeyearormonth), incorrectly bumpingarg_countto 3.The one-line fix changes the condition from checking
tz is Noneto checking"tzinfo" not in kwargs, which correctly distinguishes "tzinfo wasn't passed" from "tzinfo was explicitly passed as None."Test plan
test_no_args_tzinfo_none—get(tzinfo=None)behaves likeget()test_one_arg_str_tzinfo_none—get("2013-01-01", tzinfo=None)parses as UTCtest_two_args_str_str_tzinfo_none—get("2013-01-01", "YYYY-MM-DD", tzinfo=None)parses as UTC (the exact case from the issue)