Skip to content

Fix Ukrainian seconds and add weeks#1250

Open
nykula wants to merge 1 commit intoarrow-py:masterfrom
nykula:master
Open

Fix Ukrainian seconds and add weeks#1250
nykula wants to merge 1 commit intoarrow-py:masterfrom
nykula:master

Conversation

@nykula
Copy link
Copy Markdown

@nykula nykula commented Feb 20, 2026

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
    Fixes a crash and a mistake so there's no documentation to change.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

In locales.py, changed the Ukrainian second declension to match every other form, removed extra words from seconds (5 a few seconds -> 5 seconds), wrote split singular/dual/plural forms for seconds, added week and weeks.

The weeks change is necessary to fix errors in the PieFed federated link aggregator UI that started appearing since turning; others just made sense to correct right away if updating the locale already.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b423717) to head (65b21f5).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1250   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2315      2315           
  Branches       358       358           
=========================================
  Hits          2315      2315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant