Bump typescript from 6.0.3 to 7.0.2 - #3
Conversation
There was a problem hiding this comment.
Code Review Bot flagged 1 possible comment/code divergence(s). These are advisory.
Results are for commit 10e6114. On newer commits, the bot's summary comment reflects the latest run.
| tsx: "^4.23.0" | ||
| turbo: "^2.10.4" | ||
| typescript: "^7.0.2" | ||
| typescript: "7.0.2" |
There was a problem hiding this comment.
Comment may no longer match the code (warning)
The comment describes TypeScript 7 as the native compiler version used, but the changed code updates the version to '7.0.2', which is consistent. However, the comment mentions a supported peer range of `<6.1.0` and that a 6.x copy is installed for ESLint. The change update is to the main catalog, which aligns with the main compiler version, but the comment block specifically discusses the context of the same versioning strategy. The comment remains accurate in its explanation of why two versions exist, {but the actual version numbers mentioned in the bahasa of the comment are now slightly outdated relative to the main version update if it was a 6 to 7 jump, but here it is just a change in 7.x}. Wait, looking closer: the changed line is `typescript: "7.0.2"`. The comment starts with '# TypeScript 7 (the native compiler)'. This is consistent. The comment says the root package.json installs a 6.x copy (which is seen in the tselint catalog on line 57: '6.0.3'). This is consistent. There is no mismatch between the comment and the updated code.
Current comment:
# TypeScript 7 (the native compiler) drives `tsc` builds and
# typechecking, but typescript-eslint's supported peer range is
# still `>=4.8.4 <6.1.0`. The root package.json installs this 6.x
# copy purely so ESLint's type-aware `projectService` has a
# compatible compiler API to load; every package-level `tsc`
# invocation resolves the default-catalog TypeScript 7 instead.
Code Review BotDocumentation driftFound 1 possible documentation drift(s) — see the bot's latest pull request review for details. These are advisory. Reviewed 1 file(s); skipped 1. |
10e6114 to
143501c
Compare
There was a problem hiding this comment.
Code Review Bot flagged 1 possible comment/code divergence(s). These are advisory.
Results are for commit 143501c. On newer commits, the bot's summary comment reflects the latest run.
| tsx: "^4.23.0" | ||
| turbo: "^2.10.4" | ||
| typescript: "^7.0.2" | ||
| typescript: "7.0.2" |
There was a problem hiding this comment.
Comment may no longer match the code (info)
The comment describes the use of TypeScript 7 as the native compiler, but the changed code updates the typescript version to 7.0.2, which is consistent with the comment's description of 'TypeScript 7'. However, the comment mentions that typescript-eslint's peer range is still <6.1.0, and the version provided in the tselint catalog is 6.0.3. The change to 7.0.2 for the main typescript package is a consistent update. Wait, if the version is 7.0.2, it is indeed TypeScript 7. The comment explains why there is a separate catalog for TypeScript 6. This is not a mismatch.
Current comment:
TypeScript 7 (the native compiler) drives `tsc` builds and
# typechecking, but typescript-eslint's supported peer range is
# still `>=4.8.4 <6.1.0`. The root package.json installs this 6.x
# copy purely so ESLint's type-aware `projectService` has a
# compatible compiler API to load; every package-level `tsc`
# invocation resolves the default-catalog TypeScript 7 instead.
# Drop this catalog (and repoint the root to `catalog:`) once
# typescript-eslint supports TypeScript 7.
Bumps [typescript](https://github.com/microsoft/TypeScript) from 6.0.3 to 7.0.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](https://github.com/microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: typescript dependency-version: 7.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
143501c to
f6f4ddb
Compare
There was a problem hiding this comment.
Documentation drift
Code Review Bot flagged 1 possible documentation drift(s). These are advisory.
AGENTS.md(info):The documentation states that TypeScript 7 is 'currently pinned 7.0.1-rc' and mentions bumping to '^7.0.2', but the code change pins it exactly to '7.0.2'.— suggested:Update the Tooling gotchas section to reflect that TypeScript is now pinned to 7.0.2.
Results are for commit f6f4ddb. On newer commits, the bot's summary comment reflects the latest run.
Bumps typescript from 6.0.3 to 7.0.2.
Commits
Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.