incorporating-admission-controler - #271
Merged
Merged
Conversation
bcote-anl
changed the title
masalim2
reviewed
Jul 28, 2026
masalim2
left a comment
masalim2
left a comment
Collaborator
There was a problem hiding this comment.
This is fantastic, thank you for building this out! Many of these comments are more forward-looking considerations for future PRs; nothing is blocking the merge of this step! Let me know what you think!
masalim2
reviewed
Aug 20, 2026
masalim2
reviewed
Aug 20, 2026
masalim2
reviewed
Aug 20, 2026
masalim2
reviewed
Aug 20, 2026
Collaborator
|
Looking great! Just a handful of minor comments to address on this PR and I will populate some issues to round up the remaining ideas that we discussed for future PRs! |
light edits to pydantic models adding OpenAI Responses pydantic adding placeholder for litellm router added first pass on adding openai routes adding service files to submit inference tasks through litellm added stramlined pydantic models for OpenAI removed pydantic classes which have moved to the endpoints/ folder added not-implemented error added common base payload and enum for openai endpoints removed llm_router.py added first pass on openai routes added openai router to the main router added embeddings added embeddings dependency added skeleton for embeddings route empty deployments file with router removed old unused dev file removed inference service file since it is outdated use production policy switched to RouterConfigDep, fix argument typo added response_model=None to accomodate StreamingResponse type added return type to model_dependency List to list for typing streamlined pydantic models added str to the Enum class fixed typo in the Enum class added alias check streamlined dependency to resolve model added service orchestration file for reusable functions to find the backend added errors added admission controler dependency added admission controler to API route arguments fixed id typo. made fcts sync added placeholder for submit inference call function added numpy added numpy point to submit_inference added deployment routes
…l admitstatus reject reasons
bcote-anl
force-pushed
the
firstv2-admission-controler
branch
from
August 20, 2026 17:17
9b60ad6 to
1798d8b
Compare
added 4 commits
August 20, 2026 13:23
bcote-anl
marked this pull request as ready for review
August 20, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporating AdmissionControler to OpenAI routes
This PR includes: