Skip to content

Add rounding to Baud Rate Divisor calculation. Permits operation at …#55

Open
WestfW wants to merge 2 commits intoarduino:masterfrom
WestfW:master
Open

Add rounding to Baud Rate Divisor calculation. Permits operation at …#55
WestfW wants to merge 2 commits intoarduino:masterfrom
WestfW:master

Conversation

@WestfW
Copy link
Contributor

@WestfW WestfW commented Aug 2, 2018

The Baud Rate Generator Divisor calculations in UARTClass::init() do not round, leading to error rates higher than they could be. In particular, the error at 230400bps is both large and in the opposite direction of the 16u2 error, and it fails. Adding rounding allows it to work.

regression tested at standard speeds 9600, 19200, 38400, 57600, 115200...

…30400.

regression tested at standard speeds 9600, 19200, 38400, 57600, 115200...
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants