Repository navigation
examples: correct the Heun claim and list rfm_fisher_simplex - #16
Merged
Merged
Conversation
added 2 commits
November 3, 2026 22:02
The closing text said Heun's radius "stays near 1.0 (symplectic-like behavior)". The example's own output contradicts it: Heun's radius is 1.2106 at 10 steps and 1.0246 at 20, and it grows every step. Heun is not symplectic; on dx/dt = -y, dy/dt = x its per-step radius factor is sqrt(1 + h^4/4) against Euler's sqrt(1 + h^2), so it gains radius about h^2/4 times slower. The text now says both methods gain radius and gives the two rates. Run with `cargo run --release --example ode_comparison`; clippy -D warnings and fmt pass. Claude-Session: https://claude.ai/code/session_01UJZpXYJLkeY3RtMaiJnqSR
…ts as lists
rfm_fisher_simplex is registered with the `riemannian` feature and run by CI,
but the examples README did not list it. Add it to the feature table and the
run block.
fynch_bregman_energy printed its inputs with `{:?}` on an ndarray, which emits
`shape=[3], strides=[1], layout=CFcf (0xf), const ndim=1`. Print the values
as a plain list instead.
Claude-Session: https://claude.ai/code/session_01UJZpXYJLkeY3RtMaiJnqSR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small corrections to the examples.
ode_comparisonended with "Heun's radius stays near 1.0 (symplectic-like behavior)". Its own output shows Heun's radius at 1.2106 after 10 steps and 1.0246 after 20, growing every step. Heun is not symplectic. The closing text now says both methods gain radius, about h^2/2 per step for Euler and h^4/8 for Heun.rfm_fisher_simplexis registered under theriemannianfeature and run by CI but was missing from the examples README. It is now listed.fynch_bregman_energyprinted its inputs with ndarray's debug format (shape=[3], strides=[1], layout=CFcf ...); it now prints plain lists.Checked:
cargo fmt --check,cargo clippy --release -D warningson both changed examples, and both examples run with exit 0.