Conversation
…_context_vm_entry
Author
|
@equation314 ci fixed. |
…r flow in HANDLE_LOWER macro
chyyuu
requested review from
aarkegz,
equation314,
hky1999,
shilei-massclouds and
yfblock
and removed request for
equation314
September 5, 2025 03:28
Contributor
|
Does this PR bring virtualization support back into Arceos again? @aarkegz If we want to integrate hypervisor into ArceOS, maybe we should refer to ARM/KVM with ARM VHE support? |
aarkegz
reviewed
Sep 5, 2025
| access_flags |= PageFaultFlags::USER; | ||
| } | ||
| let vaddr = va!(FAR_EL1.get() as usize); | ||
| let vaddr = va!(elx!(FAR.get()) as usize); |
Contributor
There was a problem hiding this comment.
Will elx!(FAR).get() be a better syntax?
|
|
||
| #[cfg(feature = "arm-el2")] | ||
| #[unsafe(no_mangle)] | ||
| fn handle_sync_exception(tf: &mut TrapFrame) { |
Contributor
There was a problem hiding this comment.
Is it possible to merge these two handle_sync_exceptions? As they are very similar.
equation314
reviewed
Sep 9, 2025
| /// | ||
| /// This function is marked as `naked` to avoid the compiler generating a prologue/epilogue, | ||
| #[unsafe(naked)] | ||
| pub unsafe extern "C" fn enter_guest() -> ! { |
Member
There was a problem hiding this comment.
Add Registers as the argument.
| /// | ||
| /// This function is marked as `naked` to avoid the compiler generating a prologue/epilogue, | ||
| #[unsafe(naked)] | ||
| pub unsafe extern "C" fn enter_guest() -> ! { |
Member
There was a problem hiding this comment.
Create a structure like UspaceContext to put this function?
equation314
reviewed
Sep 9, 2025
| #[cfg(not(feature = "arm-el2"))] | ||
| { | ||
| paste::paste! { | ||
| aarch64_cpu::registers::[<$name _EL1>].$e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add aarch64 el2 trap handle support.