feat: identify requests as the Terraform provider, not the Go SDK - #52
Merged
Merged
Conversation
Appwrite attributes API key usage by x-sdk-name and classifies deployments by x-sdk-language, so reporting the Go SDK's values made provider traffic indistinguishable from direct SDK use.
Contributor
|
levivannoort
approved these changes
Sep 28, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The provider only overrode
User-Agent. Every other SDK identity header still reported the Go SDK, so Appwrite attributed Terraform traffic to it. The server readsx-sdk-nameto record which SDKs used an API key, andx-sdk-languageto classify deployments.Requests now send:
user-agentterraform-provider-appwrite/<ver>Terraform/<tf ver> terraform-provider-appwrite/<ver> AppwriteGoSDK/v7.5.0 (<os>; <arch>)+TF_APPEND_USER_AGENTx-sdk-nameGoTerraformx-sdk-platformserverserverx-sdk-languagegoterraformx-sdk-versionv7.5.0WithUserAgentis replaced bycommon.WithIdentity(providerVersion, terraformVersion), fedreq.TerraformVersionfromConfigure. The Terraform token is omitted when core doesn't report a version. The SDK token is read from the header the SDK already set, so it stays accurate across SDK bumps.HTTPConfig.UserAgentfield and a stale comment onAppendedUserAgent.Server-side follow-up: API keys only record
x-sdk-namevalues that match a server SDK inapp/config/sdks.php, soTerraformwon't appear in a key'ssdkslist until the server accepts it. Separately,app/controllers/shared/api.phpcompares the header case-sensitively against a lowercase list, so standard keys never record any SDK today.Type of Change
Checklist
make lintpassesmake testpassesmake docshas been run and changes committed (no schema or docs changes)