Fix/xwing integrity length check#445
Open
sverma98015-commits wants to merge 3 commits into
Open
Conversation
…Wing integrityCheckedRepresentation init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce correct byte size check and prevent out-of-bounds slicing in X-Wing
integrityCheckedRepresentationinitializer.Checklist
Motivation
The
XWingMLKEM768X25519.PrivateKeyinitializer forintegrityCheckedRepresentationpreviously enforced a guard check requiring a total count of 96 bytes. However, the X-Wing private key structure under the hood expects a 32-byte seed representation concatenated with a 32-byte SHA3-256 public key hash suffix, making the actual payload size exactly 64 bytes.Because of this size mismatch, passing a valid 64-byte representation threw an
incorrectParameterSizeerror. Additionally, attempting to slice the trailing 32 bytes using.dropFirst(32)on a strictly 64-byte collection was prone to slicing index issues depending on the underlyingDataProtocolbacking type.Modifications
init(integrityCheckedRepresentation:)from96to strictly enforce64bytes.publicKeyHashBytesto use.suffix(32), ensuring a reliable slice of the final 32 bytes regardless of the input data layout.Result
integrityCheckedRepresentationkeys can now be successfully initialized without triggering a parameter size mismatch error.XWingTestsnow pass successfully.