Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2469 +/- ##
==========================================
- Coverage 94.25% 94.25% -0.01%
==========================================
Files 184 184
Lines 13690 13690
==========================================
- Hits 12904 12903 -1
- Misses 786 787 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
networkidle wait in block_requests testnetworkidle waits in block_requests tests
vdusek
marked this pull request as ready for review
November 18, 2026 07:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_block_requests_defaulttimed out on Windows CI inpage.wait_for_load_state('networkidle')after the blocked page loaded (run).networkidlewaits until Playwright's own list of in-flight requests is empty for 500 ms. On the loaded runner one request stayed on that list, so the wait ran for the full 30 s.The tests do not need
networkidle.page.gotoalready waits for theloadevent, and the browser firesloadonly after the script and image requests have finished or failed. This PR removes thenetworkidlewait from all threeblock_requeststests.The two tests with custom patterns also counted only
requestfinishedevents, so a transport error such asnet::ERR_NO_BUFFER_SPACEon a loaded Windows runner failed them. They now usetrack_requests, like the default test, and assert which requests were requested and which were blocked.I could not reproduce the timeout on Linux (0 failures in 600 runs under xdist), so the Windows CI run is the real check.
✍️ Drafted by Claude Code