Remove Loader startup/shutdown as it's not needed#85
Merged
tofu-rocketry merged 1 commit intoapel:devfrom Mar 12, 2026
Merged
Conversation
We don't need to startup and shutdown the Loader as we're not running it as a Daemon. We're invoking its load_msg method and passing it a message to load directly.
Contributor
|
I thought about this when I implemented it the first time. But I couldn't remember what I had decided before my VM died, and then when I was rushing to rewrite the code on the new VM before I went on leave, I thought it was safer to leave in. |
rowan04
approved these changes
Mar 12, 2026
Member
Author
Fair enough. When working through a fresh deployment I realised it would need a lot more configuration to work if we're running the Loader as a Daemon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to startup and shutdown the Loader as we're not running it as a Daemon. We're invoking its
load_msgmethod and passing it a message to load directly.