Repository navigation
Conversation
|
/retest |
|
Jenkins build #1 reached compilation and failed only in two unrelated tests: |
anmolnar
left a comment
There was a problem hiding this comment.
You don't need to write unit test to cover a log level change.
|
@anmolnar Removed the unit test as suggested. The PR now only contains the one-line log level change in ContainerManager.java. |
|
@Pyolar I appreciate your efforts to get this super-simple matter fixed, but I'm not fully sure the Zookeeper team is dealing in good faith with us. A PR should not have been needed for this type of change, but once given, the unneeded test could easily have been taken out before merging, and I suspect that had your PR not had the unit test, they would have insisted upon it having one, i.e., no way to win. We tried, but it's been eleven-plus months, so I cancelled the ticket. |
This change lowers the candidate container deletion log from INFO to DEBUG to avoid excessive log volume while preserving the constructor configuration log at INFO.
A regression test verifies that the candidate deletion message is emitted at DEBUG level.
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-4993
Tests:
mvn -pl zookeeper-server -am -Dtest=CreateContainerTest -Dsurefire.failIfNoSpecifiedTests=false testmvn -pl zookeeper-server -am -DskipTests compile checkstyle:check spotbugs:checkmvn verify spotbugs:check checkstyle:check -Pfull-build -Dsurefire-forkcount=4reached 3,239 tests. It reported 7 unrelated OCSP/SSL failures inClientSSLRevocationTestandQuorumSSLTest; allCreateContainerTesttests passed.