YETUS-1271. Fix javadoc build#383
Conversation
aw-was-here
force-pushed
the
yetus-1271-javadoc
branch
from
afc179c to
5e41b61
Compare
aw-was-here
force-pushed
the
yetus-1271-javadoc
branch
from
5e41b61 to
25dbc2c
Compare
|
I think I'm still getting a -1 because the main branch is failing. That feels like a bug but I know there was a reason for it a long time ago. haha. |
ndimiduk
left a comment
ndimiduk
left a comment
There was a problem hiding this comment.
I guess we don't have a 1.0 release yet, so we're okay to make breaking changes. Would be good to have a release note.
| } | ||
|
|
||
| /** The doclet environment processor. */ | ||
| private DocletEnvironmentProcessor processor = |
There was a problem hiding this comment.
FYI, making this private is a compatibility-breaking change.
There was a problem hiding this comment.
Oops ok yes let me revert that bit.
There was a problem hiding this comment.
A lot of this is fallout from upgrading the apache pom which sets a bunch of stuff that it didn't before.
Yeah that behavior never sat well with me. Seems like, if master is failing a check and the branch fixes that check, that should be overall +1. |
2 participants
No description provided.